View Issue Details

IDProjectCategoryView StatusLast Update
0000528OpenFOAM[All Projects] Bugpublic2012-05-15 16:27
Reporteruser430Assigned Touser4 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinuxOSOpenSuseOS Version11.3
Product Version 
Fixed in Version 
Summary0000528: wrong radial velocity in cylindricalInletVelocityFvPatchVectorField
Descriptionin line 140 operator==(tangVel + axis_*axialVelocity_ + radialVelocity_*d);
the d vector is not normalized so the actual radial velocity imposed by the BC is multiplied by the physical radius.

e second bug is the use of axis_ instead of hatAxis which has the same direction but magnitude equal to one by construction.

I believe the code should be something like:
operator==(tangVel + hatAxis*axialVelocity_ + radialVelocity_*d/mag(d));
TagsNo tags attached.

Activities

user21

2012-05-04 11:05

  ~0001305

Thanks for the report. The bug was fixed in commit:
15378e2f165c8389f3ddebaa9482940a607f6fbb

user430

2012-05-04 11:45

  ~0001306

Actually there is a second bug related to the use of tmp for the vectorField d.
With current implementation when updating operator== the code give the following error:

temporary deallocated
    From function const T& Foam::tmp<T>::operator()() const

Simply changing line 135 from
tmp<vectorField> d = r - (hatAxis & r)*hatAxis;
to
vectorField d = r - (hatAxis & r)*hatAxis;
will solve the issue.

user4

2012-05-15 16:27

  ~0001318

Fixed in cae1e2db065268a6d39d0e15e29a860b53705d00.

Thanks for reporting!

Issue History

Date Modified Username Field Change
2012-05-03 17:20 user430 New Issue
2012-05-03 17:50 user2 Assigned To => user21
2012-05-03 17:50 user2 Status new => assigned
2012-05-04 11:05 user21 Note Added: 0001305
2012-05-04 11:05 user21 Status assigned => resolved
2012-05-04 11:05 user21 Resolution open => fixed
2012-05-04 11:45 user430 Note Added: 0001306
2012-05-04 11:45 user430 Status resolved => feedback
2012-05-04 11:45 user430 Resolution fixed => reopened
2012-05-15 16:27 user4 Note Added: 0001318
2012-05-15 16:27 user4 Status feedback => resolved
2012-05-15 16:27 user4 Fixed in Version => 2.1.x
2012-05-15 16:27 user4 Resolution reopened => fixed
2012-05-15 16:27 user4 Assigned To user21 => user4