View Issue Details

IDProjectCategoryView StatusLast Update
0000048OpenFOAM[All Projects] Bugpublic2010-10-07 18:02
Reporteruser19Assigned Tohenry 
PrioritylowSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0000048: dirname computation bug in makeThirdPartyFunctions
DescriptionIn the function cpMakeFiles the dirname of the file to copy is computed with ${i%%/*}, while it should be ${i%/*}. Otherwise everything up to the _first_ / will be deleted, instead of the _last_ slash.

This causes the function to copy all the files into <package>/Make/ instead of <package>/<dirname>/Make/.
Steps To ReproduceJust run Allwmake in the ThirdParty-1.7.x directory and observe how the */Make/{options,files} are created.
Additional InformationAttached patch fixes this.
TagsUtility

Activities

user19

2010-09-25 08:38

 

0001-Fix-dirname-computation-in-makeThirdPartyFunctions.patch (808 bytes)
From 794b58ec8257a40b173dc1bfbbfeeaa42117e3b3 Mon Sep 17 00:00:00 2001
From: Michael Wild <themiwi@users.sourceforge.net>
Date: Sat, 25 Sep 2010 09:24:40 +0200
Subject: [PATCH] Fix dirname computation in makeThirdPartyFunctions

Signed-off-by: Michael Wild <themiwi@users.sourceforge.net>
---
 tools/makeThirdPartyFunctions |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/makeThirdPartyFunctions b/tools/makeThirdPartyFunctions
index 9106251..5abb092 100755
--- a/tools/makeThirdPartyFunctions
+++ b/tools/makeThirdPartyFunctions
@@ -99,7 +99,7 @@ cpMakeFiles()
 
     for i in $(cd $wmakeFiles && find . -type f)
     do
-        d=${i%%/*}   # dirname
+        d=${i%/*}   # dirname
         b=${i##*/}   # basename
 
         mkdir -p $dst/$d/Make 2>/dev/null
-- 
1.7.2.3

henry

2010-09-28 20:18

manager   ~0000055

Thanks for the big-fix, this will be included in the next release of the ThirdParty pack.

Issue History

Date Modified Username Field Change
2010-09-25 08:38 user19 New Issue
2010-09-25 08:38 user19 File Added: 0001-Fix-dirname-computation-in-makeThirdPartyFunctions.patch
2010-09-28 20:03 henry Assigned To => henry
2010-09-28 20:03 henry Status new => assigned
2010-09-28 20:18 henry Note Added: 0000055
2010-09-28 20:18 henry Status assigned => resolved
2010-09-28 20:18 henry Resolution open => fixed
2010-10-07 18:02 user2 Tag Attached: Utility