View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004135 | OpenFOAM | Patch | public | 2024-08-12 16:04 | 2024-08-13 10:39 |
Reporter | wyldckat | Assigned To | will | ||
Priority | low | Severity | text | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Platform | GNU/Linux | OS | Other | OS Version | (please specify) |
Product Version | dev | ||||
Fixed in Version | dev | ||||
Summary | 0004135: MarshakRadiationFixedTemperature has the wrong help description for T | ||||
Description | In the header file 'MarshakRadiationFixedTemperatureFvPatchScalarField.H', the table describing the parameters is wrong. It refers to 'T' instead of 'Trad'. Please find in attachment the fixes: - wrong_T_header_entry_v1.patch - the patch file to make it easier to see the changes. - MarshakRadiationFixedTemperatureFvPatchScalarField.H - is the modified file. - wrong_T_header_entry_v1.tar.gz - contains the modified file at the correct location. | ||||
Tags | No tags attached. | ||||
|
MarshakRadiationFixedTemperatureFvPatchScalarField.H (5,799 bytes)
/*---------------------------------------------------------------------------*\ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | Website: https://openfoam.org \\ / A nd | Copyright (C) 2011-2024 OpenFOAM Foundation \\/ M anipulation | ------------------------------------------------------------------------------- License This file is part of OpenFOAM. OpenFOAM is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. OpenFOAM is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenFOAM. If not, see <http://www.gnu.org/licenses/>. Class Foam::MarshakRadiationFixedTemperatureFvPatchScalarField Description A 'mixed' boundary condition that implements a Marshak condition for the incident radiation field (usually written as G) The radiation temperature field across the patch is supplied by the user using the \c Trad entry. Usage \table Property | Description | Required | Default value Trad | radiation temperature field | yes | \endtable Example of the boundary condition specification: \verbatim <patchName> { type MarshakRadiationFixedTemperature; Trad uniform 1000; // radiation temperature field value uniform 0; // place holder } \endverbatim See also Foam::radiationCoupledBase Foam::mixedFvPatchField SourceFiles MarshakRadiationFixedTemperatureFvPatchScalarField.C \*---------------------------------------------------------------------------*/ #ifndef MarshakRadiationFixedTemperatureFvPatchScalarField_H #define MarshakRadiationFixedTemperatureFvPatchScalarField_H #include "mixedFvPatchFields.H" #include "radiationCoupledBase.H" // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // namespace Foam { /*---------------------------------------------------------------------------*\ Class MarshakRadiationFixedTemperatureFvPatchScalarField Declaration \*---------------------------------------------------------------------------*/ class MarshakRadiationFixedTemperatureFvPatchScalarField : public mixedFvPatchScalarField, public radiationCoupledBase { // Private Data //- Radiation temperature field scalarField Trad_; public: //- Runtime type information TypeName("MarshakRadiationFixedTemperature"); // Constructors //- Construct from patch, internal field and dictionary MarshakRadiationFixedTemperatureFvPatchScalarField ( const fvPatch&, const DimensionedField<scalar, volMesh>&, const dictionary& ); //- Construct by mapping given MarshakRadiationFvPatchField onto a new // patch MarshakRadiationFixedTemperatureFvPatchScalarField ( const MarshakRadiationFixedTemperatureFvPatchScalarField&, const fvPatch&, const DimensionedField<scalar, volMesh>&, const fieldMapper& ); //- Disallow copy without setting internal field reference MarshakRadiationFixedTemperatureFvPatchScalarField ( const MarshakRadiationFixedTemperatureFvPatchScalarField& ) = delete; //- Copy constructor setting internal field reference MarshakRadiationFixedTemperatureFvPatchScalarField ( const MarshakRadiationFixedTemperatureFvPatchScalarField&, const DimensionedField<scalar, volMesh>& ); //- Construct and return a clone setting internal field reference virtual tmp<fvPatchScalarField> clone ( const DimensionedField<scalar, volMesh>& iF ) const { return tmp<fvPatchScalarField> ( new MarshakRadiationFixedTemperatureFvPatchScalarField ( *this, iF ) ); } // Member Functions // Access //- Return the radiation temperature const scalarField& Trad() const { return Trad_; } //- Return reference to the radiation temperature to allow // adjustment scalarField& Trad() { return Trad_; } // Mapping functions //- Map the given fvPatchField onto this fvPatchField virtual void map(const fvPatchScalarField&, const fieldMapper&); //- Reset the fvPatchField to the given fvPatchField // Used for mesh to mesh mapping virtual void reset(const fvPatchScalarField&); // Evaluation functions //- Update the coefficients associated with the patch field virtual void updateCoeffs(); // I-O //- Write virtual void write(Ostream&) const; }; // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // } // End namespace Foam // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // #endif // ************************************************************************* // wrong_T_header_entry_v1.patch (904 bytes)
diff --git a/src/radiationModels/derivedFvPatchFields/MarshakRadiationFixedTemperature/MarshakRadiationFixedTemperatureFvPatchScalarField.H b/src/radiationModels/derivedFvPatchFields/MarshakRadiationFixedTemperature/MarshakRadiationFixedTemperatureFvPatchScalarField.H index 6c6f4b64a5..1d235093b2 100644 --- a/src/radiationModels/derivedFvPatchFields/MarshakRadiationFixedTemperature/MarshakRadiationFixedTemperatureFvPatchScalarField.H +++ b/src/radiationModels/derivedFvPatchFields/MarshakRadiationFixedTemperature/MarshakRadiationFixedTemperatureFvPatchScalarField.H @@ -34,7 +34,7 @@ Description Usage \table Property | Description | Required | Default value - T | temperature field name | no | T + Trad | radiation temperature field | yes | \endtable Example of the boundary condition specification: |
|
Thanks for the report. Fixed here: https://github.com/OpenFOAM/OpenFOAM-dev/commit/1b1a240785a89bc225653714d9238e57a6113f83 |
Date Modified | Username | Field | Change |
---|---|---|---|
2024-08-12 16:04 | wyldckat | New Issue | |
2024-08-12 16:04 | wyldckat | File Added: wrong_T_header_entry_v1.tar.gz | |
2024-08-12 16:04 | wyldckat | File Added: MarshakRadiationFixedTemperatureFvPatchScalarField.H | |
2024-08-12 16:04 | wyldckat | File Added: wrong_T_header_entry_v1.patch | |
2024-08-13 10:39 | will | Assigned To | => will |
2024-08-13 10:39 | will | Status | new => resolved |
2024-08-13 10:39 | will | Resolution | open => fixed |
2024-08-13 10:39 | will | Fixed in Version | => dev |
2024-08-13 10:39 | will | Note Added: 0013370 |