View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004106 | OpenFOAM | Bug | public | 2024-07-01 10:29 | 2024-07-02 14:38 |
| Reporter | cgoessni | Assigned To | will | ||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | dev | ||||
| Fixed in Version | dev | ||||
| Summary | 0004106: stopAtTimeStep does not convert input from userTime to real time | ||||
| Description | When using stopAtTimeStep function object, we see unexpected stops when having userUnit engine in place, since stopAtTimeStep misses a conversion from userTime to real time. | ||||
| Additional Information | This diff solves the issue for us: diff --git a/src/functionObjects/utilities/stopAt/stopAtTimeStep/stopAtTimeStep.C b/src/functionObjects/utilities/stopAt/stopAtTimeStep/stopAtTimeStep.C index 8ca4fc7..c920b77 100644 --- a/src/functionObjects/utilities/stopAt/stopAtTimeStep/stopAtTimeStep.C +++ b/src/functionObjects/utilities/stopAt/stopAtTimeStep/stopAtTimeStep.C @@ -81,7 +81,7 @@ Foam::functionObjects::stopAtTimeStep::~stopAtTimeStep() bool Foam::functionObjects::stopAtTimeStep::read(const dictionary& dict) { stopAt::read(dict); - dict.lookup("minDeltaT") >> minDeltaT_; + minDeltaT_ = dict.lookup<scalar>("minDeltaT", time_.userUnits()); return true; } | ||||
| Tags | No tags attached. | ||||
|
|
I meant userTime engine, not userTime. |
|
|
Thanks. Resolved here: https://github.com/OpenFOAM/OpenFOAM-dev/commit/51a233771829cc35b3c31e69486ee29b8c051eaa |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-07-01 10:29 | cgoessni | New Issue | |
| 2024-07-01 15:33 | cgoessni | Note Added: 0013290 | |
| 2024-07-02 14:38 | will | Assigned To | => will |
| 2024-07-02 14:38 | will | Status | new => resolved |
| 2024-07-02 14:38 | will | Resolution | open => fixed |
| 2024-07-02 14:38 | will | Fixed in Version | => dev |
| 2024-07-02 14:38 | will | Note Added: 0013299 |
