View Issue Details

IDProjectCategoryView StatusLast Update
0004101OpenFOAMPatchpublic2024-06-19 10:59
Reportermichael_h Assigned Towill  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformUnixOSOtherOS Version(please specify)
Product Versiondev 
Fixed in Versiondev 
Summary0004101: Mesh motion does not work together with NCC
DescriptionWhen I try to use the componentVelocity motion solver together with NCC then foamRun of OpenFOAM-dev aborts with:

--> FOAM FATAL ERROR:
Not implemented

    From function Foam::tmp<Foam::Field<Type> > Foam::fvPatchField<Type>::gradientInternalCoeffs() const [with Type = double]
    in file lnInclude/fvPatchField.H at line 485.

FOAM aborting

OpenFOAM-11 fails with a different problem when the meshToMesh mapping is performed.

I use openSUSE Leap 15.6.
Steps To ReproduceUse attached test case an try to run it.
Additional InformationA proposed fix is also attached.
TagsNo tags attached.

Activities

michael_h

2024-06-18 20:27

reporter  

movingConeNCC.tar.gz (5,035 bytes)
meshMotionNCC-fix.diff (1,091 bytes)   
diff --git a/src/finiteVolume/fvMesh/fvMeshStitchers/fvMeshStitcher/conformedFvPatchField.C b/src/finiteVolume/fvMesh/fvMeshStitchers/fvMeshStitcher/conformedFvPatchField.C
index 6b2f6aee69..1dc6d1aa7d 100644
--- a/src/finiteVolume/fvMesh/fvMeshStitchers/fvMeshStitcher/conformedFvPatchField.C
+++ b/src/finiteVolume/fvMesh/fvMeshStitchers/fvMeshStitcher/conformedFvPatchField.C
@@ -152,6 +152,9 @@ void Foam::conformedFvPatchField<Type>::conform
 {
     const DimensionedField<Type, volMesh>& iF = bF[0].internalField();
 
+    if (iF.name().find("cellDisplacement") == 0) return;
+    if (iF.name().find("cellMotion") == 0) return;
+
     const fvBoundaryMesh& fvbm = iF.mesh().boundary();
 
     const labelList origPatchIndices =
@@ -311,6 +314,9 @@ void Foam::conformedFvPatchField<Type>::unconform
 {
     const DimensionedField<Type, volMesh>& iF = bF[0].internalField();
 
+    if (iF.name().find("cellDisplacement") == 0) return;
+    if (iF.name().find("cellMotion") == 0) return;
+
     const fvBoundaryMesh& fvbm = iF.mesh().boundary();
 
     const labelList origPatchIndices =
meshMotionNCC-fix.diff (1,091 bytes)   

will

2024-06-19 10:59

manager   ~0013279

Thanks for the report. Good case, easily reproduced. Fixed here:

https://github.com/OpenFOAM/OpenFOAM-dev/commit/7a58f30c5605e3bf1b6681a354916071326478b8

The case now runs to completion.

Any remaining problems with v11 and interoperability of mesh change processes probably aren't fixable. We have made a lot of changes in the last year in regards to running multiple modes of mesh change simultaneously. Dev is quite different from v11 in this regard as a result, and many of the fixes therefore cannot be ported back to v11 without breaking backwards compatibility. So, if you can demonstrate a bug in v11 you are welcome to file another report, but be aware that there is a high probability that we won't be able to fix it.

Issue History

Date Modified Username Field Change
2024-06-18 20:27 michael_h New Issue
2024-06-18 20:27 michael_h File Added: movingConeNCC.tar.gz
2024-06-18 20:27 michael_h File Added: meshMotionNCC-fix.diff
2024-06-19 10:59 will Assigned To => will
2024-06-19 10:59 will Status new => resolved
2024-06-19 10:59 will Resolution open => fixed
2024-06-19 10:59 will Fixed in Version => dev
2024-06-19 10:59 will Note Added: 0013279