View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004063 | OpenFOAM | Bug | public | 2024-03-08 19:32 | 2024-03-12 12:26 |
| Reporter | joaquin | Assigned To | will | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | GNU/Linux | OS | Ubuntu | OS Version | 15.04 |
| Product Version | 11 | ||||
| Fixed in Version | dev | ||||
| Summary | 0004063: Sign error in Pilch-Erdman breakup model | ||||
| Description | There is a typo in the original paper, as pointed out in: Guildenbecher et al. Secondary atomization. Exp Fluids (2009) 46:371–402, pp. 389 In PilchErdman.C, line 118: taubBar = 14.1*pow(We - 12.0, 0.25); the correct equation is: taubBar = 14.1*pow(We - 12.0, -0.25); | ||||
| Steps To Reproduce | not applicable | ||||
| Additional Information | not applicable | ||||
| Tags | No tags attached. | ||||
|
|
There is a difference in the published equations, yes. Snippets of the references are attached. It is not clear to me, which of Pilch-Erdman eq10 and Guildenbecher eq33 are correct. Can you elaborate on why you consider Guildenbecher to be correct? Guildenbecher's does state a correction to Pilch-Erdman, but this relates to a different equation; i.e., Pilch-Erdman eq13 and Guildenbecher eq34 (also in attched). This equation does not appear in the implementation, however, so there is no issue with this difference. |
|
|
If one uses OP's correction, the function for taubBar becomes continuous in We: original Pilch-Erdman: T(45-) = 5.87 T(45+) = 33.79 T(351-) = 60.50 T(351+) = 3.29 new Guildenbecher: T_tot(45-) = 5.87 T_tot(45+) = 5.88 T_tot(351-) = 3.29 T_tot(351+) = 3.29 |
|
|
OK, yes. I see. Good point. And only the changed function matches the graphs in the original reference. Thanks. Fixed in dev: https://github.com/OpenFOAM/OpenFOAM-dev/commit/d9cb93897ac2c829a319378374e0ac523be5ce9c |
|
|
And v11. https://github.com/OpenFOAM/OpenFOAM-11/commit/71b07bb46985607e3b78e9404e8b5129989de411 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-03-08 19:32 | joaquin | New Issue | |
| 2024-03-12 08:54 | will | Note Added: 0013209 | |
| 2024-03-12 08:54 | will | File Added: Guildenbecher_bug4063.pdf | |
| 2024-03-12 08:54 | will | File Added: Pilch-Erdman_bug4063.pdf | |
| 2024-03-12 08:55 | will | Note Edited: 0013209 | |
| 2024-03-12 11:04 | cgoessni | Note Added: 0013210 | |
| 2024-03-12 12:23 | will | Assigned To | => will |
| 2024-03-12 12:23 | will | Status | new => resolved |
| 2024-03-12 12:23 | will | Resolution | open => fixed |
| 2024-03-12 12:23 | will | Fixed in Version | => dev |
| 2024-03-12 12:23 | will | Note Added: 0013211 | |
| 2024-03-12 12:26 | will | Note Added: 0013212 |
