View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003938 | OpenFOAM | Bug | public | 2022-11-29 06:58 | 2022-11-29 14:36 |
Reporter | cgoessni | Assigned To | henry | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | dev | ||||
Fixed in Version | dev | ||||
Summary | 0003938: timeActivatedFileUpdate: missing timeToUserTime conversion | ||||
Description | timeActivatedFileUpdate is missing a timeToUserTime conversion. Additionally, the time check might be better if "<=" was used, since with the current version "<", the file update would be one time step too late. Proposed diff attached. | ||||
Tags | No tags attached. | ||||
|
diff_timeActivatedFileUpdate.txt (650 bytes)
diff --git a/src/functionObjects/utilities/timeActivatedFileUpdate/timeActivatedFileUpdate.C b/src/functionObjects/utilities/timeActivatedFileUpdate/timeActivatedFileUpdate.C index c8e3847..bdbccf6 100644 --- a/src/functionObjects/utilities/timeActivatedFileUpdate/timeActivatedFileUpdate.C +++ b/src/functionObjects/utilities/timeActivatedFileUpdate/timeActivatedFileUpdate.C @@ -54,7 +54,7 @@ void Foam::functionObjects::timeActivatedFileUpdate::updateFile() while ( i < timeVsFile_.size()-1 - && timeVsFile_[i+1].first() < time_.value() + && timeVsFile_[i+1].first() <= time_.userTimeValue() ) { i++; |
|
Thanks for reporting. Resolved by commit 303c0167045dcd13905abbebaa4c52fc5d912ceb |
Date Modified | Username | Field | Change |
---|---|---|---|
2022-11-29 06:58 | cgoessni | New Issue | |
2022-11-29 06:58 | cgoessni | File Added: diff_timeActivatedFileUpdate.txt | |
2022-11-29 14:36 | henry | Assigned To | => henry |
2022-11-29 14:36 | henry | Status | new => resolved |
2022-11-29 14:36 | henry | Resolution | open => fixed |
2022-11-29 14:36 | henry | Fixed in Version | => dev |
2022-11-29 14:36 | henry | Note Added: 0012902 |