View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003915 | OpenFOAM | Bug | public | 2022-10-18 12:22 | 2022-10-24 10:17 |
| Reporter | martinB | Assigned To | henry | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | GNU/Linux | OS | OpenSuSE | OS Version | 13.2 |
| Product Version | dev | ||||
| Fixed in Version | 10 | ||||
| Summary | 0003915: First summand is added twice in integratedNonUniformTable | ||||
| Description | In file src/thermophysicalModels/specie/thermophysicalFunctions/integratedNonUniformTable1/integratedNonUniformTable1.C lines 58 and 87, and same for lines 59 and 104: The first summand "intf_[i]" is added twice, once in line 58 and then again in line 87 in the member function intfdT(). Same for intfByT_. Can someone take a quick look? | ||||
| Tags | No tags attached. | ||||
|
|
Yes, I think there is a bug and indeed intf_[i] and intfByT_ are added twice. I did a test where I defined values ( ( 298.15 1 ) ( 318.15 1 ) ( 330.15 1 ) ( 350.15 1 ) ( 370.15 1 ) ( 398.15 1 ) ); and printed out the resulting intf_. It gave 6(0 20 52 124 268 564) while the expected result would have been 6(0 20 32 52 72 100) Just writing intf_[i + 1] = intfdT(values()[i + 1].first()); intfByT_[i + 1] = intfByTdT(values()[i + 1].first()); in lines 58-59 should be correct. A made this change and it also seemed to fix https://bugs.openfoam.org/view.php?id=3918 |
|
|
Resolved in OpenFOAM-10 by commit 6327ab2820105ef9e77d7dd69c0d5b8e6b5cbeb4 Resolved in OpenFOAM-dev by commit d551993e89652771a39850d0b5a807f6782953aa |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-10-18 12:22 | martinB | New Issue | |
| 2022-10-24 08:29 | tniemi | Note Added: 0012831 | |
| 2022-10-24 10:17 | henry | Assigned To | => henry |
| 2022-10-24 10:17 | henry | Status | new => resolved |
| 2022-10-24 10:17 | henry | Resolution | open => fixed |
| 2022-10-24 10:17 | henry | Fixed in Version | => 10 |
| 2022-10-24 10:17 | henry | Note Added: 0012833 |
