View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003787 | OpenFOAM | Bug | public | 2022-01-20 12:13 | 2022-01-20 15:39 |
| Reporter | wyldckat | Assigned To | henry | ||
| Priority | low | Severity | minor | Reproducibility | sometimes |
| Status | resolved | Resolution | fixed | ||
| Product Version | dev | ||||
| Fixed in Version | dev | ||||
| Summary | 0003787: 'lnInclude' for 'solidSpecie' is not updated automatically | ||||
| Description | This is a somewhat rare issue, given that it's rare to have folders without a 'Make' folder that are common to several other libraries and need the 'lnInclude' folder. In the folder 'src/thermophysicalModels', if we update the symbolic link folders, it does not process the folder 'solidSpecie', e.g.: src cd thermophysicalModels wmakeLnIncludeAll -update wmakeLnIncludeAll: running wmakeLnInclude searching . for 'Make' directories wmakeLnInclude: linking include files to ./basic/lnInclude wmakeLnInclude: linking include files to ./chemistryModel/lnInclude wmakeLnInclude: linking include files to ./reactionThermo/lnInclude wmakeLnInclude: linking include files to ./laminarFlameSpeed/lnInclude wmakeLnInclude: linking include files to ./thermophysicalProperties/lnInclude wmakeLnInclude: linking include files to ./barotropicCompressibilityModel/lnInclude wmakeLnInclude: linking include files to ./solidThermo/lnInclude wmakeLnInclude: linking include files to ./specie/lnInclude The simplest fix would be to add this line to 'src/thermophysicalModels/Allwmake': wmakeLnInclude -update solidSpecie before all other 'wmake' calls. Other alternatives I can think of: 1- Either would require to either create a dummy library folder 'Make' with 'LIB=' inside it, at the risk of breaking something else. 2- Upgrading 'wmakeLnIncludeAll' to account for these special kinds of shared folders. 3- Have a new kind of template/header library, e.g. 'Make/files' with just a marker keyword 'INCLIB', mostly just to allow us to have a simple update to 'wmakeLnIncludeAll'. | ||||
| Steps To Reproduce | Running these commands will reproduce the issue: src cd thermophysicalModels rm solidSpecie/lnInclude/tabulatedSolidTransport* wclean solidThermo ./Allwmake -update Results in something like this: ..../OpenFOAM/OpenFOAM-dev/src/thermophysicalModels/solidSpecie/lnInclude/forSolids.H:44:10: fatal error: tabulatedSolidTransport.H: No such file or directory #include "tabulatedSolidTransport.H" ^~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. This was because 'tabulatedSolidTransport*' files were not added in the first commit, along with when 'solidSpecie' was introduced. | ||||
| Tags | No tags attached. | ||||
|
|
Try with src cd thermophysicalModels rm solidSpecie/lnInclude/tabulatedSolidTransport* wclean solidThermo wcleanLnIncludeAll ./Allwmake -update We find that Allwmake -update is not entirely reliable and sometimes does not update the lnInclude directories or .dep files correctly and manual intervention is needed. |
|
|
> 1- Either would require to either create a dummy library folder 'Make' with 'LIB=' inside it, at the risk of breaking something else. Have you tried this? |
|
|
Resolved by commit db45df2e6e7c57d4903bd30f978485edfb537b22 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-01-20 12:13 | wyldckat | New Issue | |
| 2022-01-20 12:13 | wyldckat | Status | new => assigned |
| 2022-01-20 12:13 | wyldckat | Assigned To | => henry |
| 2022-01-20 14:15 | henry | Note Added: 0012416 | |
| 2022-01-20 14:33 | henry | Note Added: 0012418 | |
| 2022-01-20 15:39 | henry | Status | assigned => resolved |
| 2022-01-20 15:39 | henry | Resolution | open => fixed |
| 2022-01-20 15:39 | henry | Fixed in Version | => dev |
| 2022-01-20 15:39 | henry | Note Added: 0012419 |
