View Issue Details

IDProjectCategoryView StatusLast Update
0003743OpenFOAMBugpublic2021-10-22 23:03
ReportermillszgAssigned Tohenry 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformGNU/LinuxOSUbuntuOS Version15.04
Product Version9 
Fixed in Version9 
Summary0003743: Possible error in unityLewisFourier::j
DescriptionIn member function j of unityLewisFourier on line 129 this->thermo().alpha() is used directly for the diffusion coefficient of the mixture. Because Fickian inherits from unityLewisFourier and calls BasicThermophysicalTransportModel::j to calculate the species mass flux, it will also use alpha instead of its calculated diffusion coefficients. I am still learning the new code and might be missing something, but I think that replacing this->thermo().alpha() with this->DEff(Yi) will ensure that the correct diffusion coefficients are used for both the Fickian and unityLewis models.
Steps To ReproduceWill occur anytime the Fickian thermophysical transport model is used for species transport.
TagsNo tags attached.

Activities

henry

2021-10-22 18:39

manager   ~0012252

> replacing this->thermo().alpha() with this->DEff(Yi)

Where are you proposing this replacement?

millszg

2021-10-22 18:46

reporter   ~0012253

Line 129 in unityLewisFourier.C:

-fvc::interpolate(this->thermo().alpha()*this->alpha())

would become:

-fvc::interpolate(this->DEff(Yi)*this->alpha())

henry

2021-10-22 22:36

manager   ~0012254

Yes, you are correct. It might make more sense to create a more general base-class which both unityLewisFourier and FickianFourier inherit to avoid the apparently inconsistent treatment of j and q.

henry

2021-10-22 23:03

manager   ~0012255

Resolved in OpenFOAM-9 by commit 046fce5c18c35d671aa417883a6fda97e3075e5c
Resolved in OpenFOAM-dev by commit c515e74e008c9e4348f85c39aa3647a325ae8d04

Issue History

Date Modified Username Field Change
2021-10-22 18:25 millszg New Issue
2021-10-22 18:39 henry Note Added: 0012252
2021-10-22 18:46 millszg Note Added: 0012253
2021-10-22 22:36 henry Note Added: 0012254
2021-10-22 23:03 henry Assigned To => henry
2021-10-22 23:03 henry Status new => resolved
2021-10-22 23:03 henry Resolution open => fixed
2021-10-22 23:03 henry Fixed in Version => 9
2021-10-22 23:03 henry Note Added: 0012255