View Issue Details

IDProjectCategoryView StatusLast Update
0003554OpenFOAMPatchpublic2020-09-29 15:16
ReporterwyldckatAssigned Towill 
PrioritynormalSeverityminorReproducibilitysometimes
Status resolvedResolutionfixed 
Product Version8 
Fixed in Version8 
Summary0003554: semiPermeableBaffleMassFraction includes a declaration of 'composition(...)' but not the definition
DescriptionIn the file 'src/specieTransfer/derivedFvPatchFields/semiPermeableBaffleMassFraction/semiPermeableBaffleMassFractionFvPatchScalarField.H' is declared:

        static const basicSpecieMixture& composition(const objectRegistry& db);

But it's not defined in the '.C' file what it does. It looks like there was a bit of an incomplete copy-paste from the class 'specieTransferMassFractionFvPatchScalarField' from which 'semiPermeableBaffleMassFractionFvPatchScalarField' inherits from, but this static method seems to be simple enough to not require a redefinition.

Attached is the proposed patch 'proposed_fix_v1.patch' and the respective updated file, namely to remove the declaration from said file.
Additional InformationFound this when compiling on Windows with MSys2 + GCC 10.2.
TagsNo tags attached.

Activities

wyldckat

2020-09-23 10:29

updater  

proposed_fix_v1.patch (890 bytes)
diff --git a/src/specieTransfer/derivedFvPatchFields/semiPermeableBaffleMassFraction/semiPermeableBaffleMassFractionFvPatchScalarField.H b/src/specieTransfer/derivedFvPatchFields/semiPermeableBaffleMassFraction/semiPermeableBaffleMassFractionFvPatchScalarField.H
index d1a033d..2324f5d 100644
--- a/src/specieTransfer/derivedFvPatchFields/semiPermeableBaffleMassFraction/semiPermeableBaffleMassFractionFvPatchScalarField.H
+++ b/src/specieTransfer/derivedFvPatchFields/semiPermeableBaffleMassFraction/semiPermeableBaffleMassFractionFvPatchScalarField.H
@@ -110,12 +110,6 @@ public:
     TypeName("semiPermeableBaffleMassFraction");
 
 
-    // Static member functions
-
-        //- Access the composition for the given database
-        static const basicSpecieMixture& composition(const objectRegistry& db);
-
-
     // Constructors
 
         //- Construct from patch and internal field
proposed_fix_v1.patch (890 bytes)
semiPermeableBaffleMassFractionFvPatchScalarField.H (6,727 bytes)

wyldckat

2020-09-23 10:29

updater   ~0011521

I forgot to mention that this is applicable to OpenFOAM 8 and dev.

will

2020-09-29 15:16

manager   ~0011551

Thanks for the report. Fixed in 8 and dev.

https://github.com/OpenFOAM/OpenFOAM-8/commit/a3389546b5b598cf4065b0729b2b4df8b12eeecd
https://github.com/OpenFOAM/OpenFOAM-dev/commit/b0d91b53a70ef8a3450abbfe6a6ad53073ed4815

Issue History

Date Modified Username Field Change
2020-09-23 10:29 wyldckat New Issue
2020-09-23 10:29 wyldckat Status new => assigned
2020-09-23 10:29 wyldckat Assigned To => henry
2020-09-23 10:29 wyldckat File Added: proposed_fix_v1.patch
2020-09-23 10:29 wyldckat File Added: semiPermeableBaffleMassFractionFvPatchScalarField.H
2020-09-23 10:29 wyldckat Note Added: 0011521
2020-09-29 15:16 will Assigned To henry => will
2020-09-29 15:16 will Status assigned => resolved
2020-09-29 15:16 will Resolution open => fixed
2020-09-29 15:16 will Fixed in Version => 8
2020-09-29 15:16 will Note Added: 0011551