View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003389OpenFOAMBugpublic2019-11-15 06:202019-11-15 09:03
Reporteradcpk Assigned Tohenry  
PriorityhighSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinuxOSUbuntuOS Version18.04.3 LTS
Summary0003389: instantaneous reaction rate is not performed
DescriptionWhen the reaction rate is set to instantaneous, the reaction is disappeared.
This bug is due to the mistake in "src/combustionModels/laminar/laminar.C", the instantaneous reaction rate is totally not performed in function "correct".

 
Steps To Reproduceadd following set in constant/combustionProperties
integrateReactionRate off;
Additional Information//openfoam6
template<class ReactionThermo>
 void Foam::combustionModels::laminar<ReactionThermo>::correct()
 {
     if (this->active())
     {
         if (integrateReactionRate_)
         {
             //some codes
         }
         else
         {
             this->chemistryPtr_->calculate();
         }
     }
 }

//openfoam7
template<class ReactionThermo>
 void Foam::combustionModels::laminar<ReactionThermo>::correct()
 {
     if (integrateReactionRate_)
     {
         //some codes
     }
 }

//suggested
template<class ReactionThermo>
 void Foam::combustionModels::laminar<ReactionThermo>::correct()
 {
     if (integrateReactionRate_)
     {
         //some codes
     }
    else
     {
         this->chemistryPtr_->calculate();
     }
 }
TagsNo tags attached.

Activities

henry

2019-11-15 09:03

manager   ~0010911

Thanks for the report.

Resolved in OpenFOAM-7 by commit ca808c8420bf6f92640a723e576ab79c830d5ed2
Resolved in OpenFOAM-dev by commit e286cf4ef942c0a6951a92e5022cb98c5ea2ad28

Issue History

Date Modified Username Field Change
2019-11-15 06:20 adcpk New Issue
2019-11-15 09:03 henry Assigned To => henry
2019-11-15 09:03 henry Status new => resolved
2019-11-15 09:03 henry Resolution open => fixed
2019-11-15 09:03 henry Fixed in Version => 7
2019-11-15 09:03 henry Note Added: 0010911