View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003262||OpenFOAM||Contribution||public||2019-05-22 21:54||2019-05-26 12:13|
|Fixed in Version||dev|
|Summary||0003262: Add power calculation to rotorDisk|
|Description||rotorDisk currently computes lift and drag (and outputs these to log). Curiously, power calculation is left out. I propose a simple change to add it in.|
|Steps To Reproduce||I've implemented it at this commit: https://github.com/openfoamtutorials/OpenFOAM-dev/commit/182507ddf566b069b1d54e76bb80f63087d2d5e5|
I've recompiled fvOptions and tested it on my machine.
|Additional Information||Implementation: https://github.com/openfoamtutorials/OpenFOAM-dev/commit/182507ddf566b069b1d54e76bb80f63087d2d5e5|
|Tags||No tags attached.|
Thanks for the proposed contribution. Have you already signed the contributor agreement? To whom should we attribute the code?
I haven't yet signed the contributor's agreement; just requested the contract. I guess I will update this thread when that is finished. All work is my own.
Slightly related, there is a typo in the info message in rotorDiskSource.C line 387, gometry should be geometry
I believe I'm all set to contribute. How do I contribute code? It seems pull requests on OpenFOAM-dev get immediately closed.
I would prefer attribution to be to my github account (through an accepted pull request...), but if you guys do name only then are you able to see my profile details?
I have your code changes and will put it in as soon as I have completed and pushed a substantial change I am working on at the moment. Should be done in a few days.
Thanks for the contribution.
Resolved by commit dfe7b86e703823a941e32eaf8033d41b148d702b
|2019-05-22 21:54||openfoamtutorials||New Issue|
|2019-05-22 22:22||henry||Note Added: 0010484|
|2019-05-22 22:39||openfoamtutorials||Note Added: 0010485|
|2019-05-24 08:51||tniemi||Note Added: 0010486|
|2019-05-24 18:06||openfoamtutorials||Note Added: 0010489|
|2019-05-24 18:35||henry||Note Added: 0010490|
|2019-05-26 12:13||henry||Assigned To||=> henry|
|2019-05-26 12:13||henry||Status||new => resolved|
|2019-05-26 12:13||henry||Resolution||open => fixed|
|2019-05-26 12:13||henry||Fixed in Version||=> dev|
|2019-05-26 12:13||henry||Note Added: 0010495|