View Issue Details

IDProjectCategoryView StatusLast Update
0003262OpenFOAMContributionpublic2019-05-26 12:13
ReporteropenfoamtutorialsAssigned Tohenry 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformGNU/LinuxOSUbuntuOS Version18.04
Product Version6 
Fixed in Versiondev 
Summary0003262: Add power calculation to rotorDisk
DescriptionrotorDisk currently computes lift and drag (and outputs these to log). Curiously, power calculation is left out. I propose a simple change to add it in.
Implementation: https://github.com/openfoamtutorials/OpenFOAM-dev/commit/182507ddf566b069b1d54e76bb80f63087d2d5e5
Steps To ReproduceI've implemented it at this commit: https://github.com/openfoamtutorials/OpenFOAM-dev/commit/182507ddf566b069b1d54e76bb80f63087d2d5e5
I've recompiled fvOptions and tested it on my machine.
Additional InformationImplementation: https://github.com/openfoamtutorials/OpenFOAM-dev/commit/182507ddf566b069b1d54e76bb80f63087d2d5e5
TagsNo tags attached.

Activities

henry

2019-05-22 22:22

manager   ~0010484

Thanks for the proposed contribution. Have you already signed the contributor agreement? To whom should we attribute the code?

See:
https://openfoam.org/dev/how-to-contribute/
https://openfoam.org/contributor-agreement/

openfoamtutorials

2019-05-22 22:39

reporter   ~0010485

Hi Henry,

I haven't yet signed the contributor's agreement; just requested the contract. I guess I will update this thread when that is finished. All work is my own.

-Robert

tniemi

2019-05-24 08:51

reporter   ~0010486

Slightly related, there is a typo in the info message in rotorDiskSource.C line 387, gometry should be geometry

https://github.com/OpenFOAM/OpenFOAM-dev/blob/0889ff91c70679a6baf8882f4543e3bd074c09c4/src/fvOptions/sources/derived/rotorDiskSource/rotorDiskSource.C#L387

openfoamtutorials

2019-05-24 18:06

reporter   ~0010489

Hi Henry,

I believe I'm all set to contribute. How do I contribute code? It seems pull requests on OpenFOAM-dev get immediately closed.
I would prefer attribution to be to my github account (through an accepted pull request...), but if you guys do name only then are you able to see my profile details?

Thanks,
Robert

henry

2019-05-24 18:35

manager   ~0010490

Hi Robert,

I have your code changes and will put it in as soon as I have completed and pushed a substantial change I am working on at the moment. Should be done in a few days.

Thanks
Henry

henry

2019-05-26 12:13

manager   ~0010495

Thanks for the contribution.
Resolved by commit dfe7b86e703823a941e32eaf8033d41b148d702b

Issue History

Date Modified Username Field Change
2019-05-22 21:54 openfoamtutorials New Issue
2019-05-22 22:22 henry Note Added: 0010484
2019-05-22 22:39 openfoamtutorials Note Added: 0010485
2019-05-24 08:51 tniemi Note Added: 0010486
2019-05-24 18:06 openfoamtutorials Note Added: 0010489
2019-05-24 18:35 henry Note Added: 0010490
2019-05-26 12:13 henry Assigned To => henry
2019-05-26 12:13 henry Status new => resolved
2019-05-26 12:13 henry Resolution open => fixed
2019-05-26 12:13 henry Fixed in Version => dev
2019-05-26 12:13 henry Note Added: 0010495