View Issue Details

IDProjectCategoryView StatusLast Update
0002927OpenFOAMPatchpublic2018-05-14 16:54
Reporterwyldckat Assigned Tohenry  
PrioritylowSeveritytextReproducibilityN/A
Status resolvedResolutionfixed 
Fixed in Versiondev 
Summary0002927: "fvOption.C" listed under 'SourceFiles' in file "fixedTemperatureConstraint.H", instead of "fixedTemperatureConstraint.C"
DescriptionThis patch can be used as-is on both OpenFOAM 5.x and dev.

Attached are the following files:

 - typo.tar.gz - contains the corrected file at the full path "src/fvOptions/constraints/fixedTemperatureConstraint/fixedTemperatureConstraint.H"

 - "fixedTemperatureConstraint.H" - the file itself, in case the tarball isn't entirely practical for a single file...

 - "typo.patch" - shows the changes made, which are listed below...


Fixes:

 1. Use the correct file under 'SourceFiles'.

 2. Added the entry "Foam::fvOption" for 'See also', as done in the sibling constraint "fixedValueConstraint".

 3. Updated the Copyright year.
TagsNo tags attached.

Activities

wyldckat

2018-05-12 17:32

updater  

typo.tar.gz (1,516 bytes)

wyldckat

2018-05-12 17:32

updater  

fixedTemperatureConstraint.H (4,147 bytes)   
/*---------------------------------------------------------------------------*\
  =========                 |
  \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
   \\    /   O peration     |
    \\  /    A nd           | Copyright (C) 2012-2018 OpenFOAM Foundation
     \\/     M anipulation  |
-------------------------------------------------------------------------------
License
    This file is part of OpenFOAM.

    OpenFOAM is free software: you can redistribute it and/or modify it
    under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    OpenFOAM is distributed in the hope that it will be useful, but WITHOUT
    ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    for more details.

    You should have received a copy of the GNU General Public License
    along with OpenFOAM.  If not, see <http://www.gnu.org/licenses/>.

Class
    Foam::fv::fixedTemperatureConstraint

Description
    Fixed temperature equation constraint

Usage
    \verbatim
    fixedTemperature
    {
        type            fixedTemperatureConstraint;
        active          yes;

        mode            uniform;      // uniform or lookup

        // For uniform option
        temperature     constant 500; // fixed temperature with time [K]

        // For lookup option
        // T            <Tname>;      // optional temperature field name
    }
    \endverbatim

Note:
    The 'uniform' option allows the use of a time-varying uniform temperature
    by means of the Function1 type.

See also
    Foam::fvOption

SourceFiles
    fixedTemperatureConstraint.C

\*---------------------------------------------------------------------------*/

#ifndef fixedTemperatureConstraint_H
#define fixedTemperatureConstraint_H

#include "cellSetOption.H"
#include "NamedEnum.H"
#include "Function1.H"

// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * //

namespace Foam
{
namespace fv
{

/*---------------------------------------------------------------------------*\
                 Class fixedTemperatureConstraint Declaration
\*---------------------------------------------------------------------------*/

class fixedTemperatureConstraint
:
    public cellSetOption
{

public:

    //- Temperature mode
    enum temperatureMode
    {
        tmUniform,
        tmLookup
    };


    //- String representation of temperatureMode enums
    static const NamedEnum<temperatureMode, 2> temperatureModeNames_;


protected:

    // Protected data

        //- Operation mode
        temperatureMode mode_;

        //- Uniform temperature [K]
        autoPtr<Function1<scalar>> Tuniform_;

        //- Temperature field name
        word TName_;


private:

    // Private Member Functions

        //- Disallow default bitwise copy construct
        fixedTemperatureConstraint(const fixedTemperatureConstraint&);

        //- Disallow default bitwise assignment
        void operator=(const fixedTemperatureConstraint&);


public:

    //- Runtime type information
    TypeName("fixedTemperatureConstraint");


    // Constructors

        //- Construct from components
        fixedTemperatureConstraint
        (
            const word& name,
            const word& modelType,
            const dictionary& dict,
            const fvMesh& mesh
        );


    //- Destructor
    virtual ~fixedTemperatureConstraint()
    {}


    // Member Functions

        //- Constrain energy equation to fix the temperature
        virtual void constrain(fvMatrix<scalar>& eqn, const label fieldi);


        // IO

            //- Read dictionary
            virtual bool read(const dictionary& dict);
};


// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * //

} // End namespace fv
} // End namespace Foam

// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * //

#endif

// ************************************************************************* //
fixedTemperatureConstraint.H (4,147 bytes)   

wyldckat

2018-05-12 17:33

updater  

typo.patch (1,126 bytes)   
diff --git a/src/fvOptions/constraints/fixedTemperatureConstraint/fixedTemperatureConstraint.H b/src/fvOptions/constraints/fixedTemperatureConstraint/fixedTemperatureConstraint.H
index 404a035..658606f 100644
--- a/src/fvOptions/constraints/fixedTemperatureConstraint/fixedTemperatureConstraint.H
+++ b/src/fvOptions/constraints/fixedTemperatureConstraint/fixedTemperatureConstraint.H
@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     |
-    \\  /    A nd           | Copyright (C) 2012-2017 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2012-2018 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -48,8 +48,11 @@ Note:
     The 'uniform' option allows the use of a time-varying uniform temperature
     by means of the Function1 type.
 
+See also
+    Foam::fvOption
+
 SourceFiles
-    fvOption.C
+    fixedTemperatureConstraint.C
 
 \*---------------------------------------------------------------------------*/
 
typo.patch (1,126 bytes)   

henry

2018-05-14 16:54

manager   ~0009569

Resolved by commit d030bb35c3417f0d6ff25480b48c82f96674f081

Issue History

Date Modified Username Field Change
2018-05-12 17:32 wyldckat New Issue
2018-05-12 17:32 wyldckat Status new => assigned
2018-05-12 17:32 wyldckat Assigned To => henry
2018-05-12 17:32 wyldckat File Added: typo.tar.gz
2018-05-12 17:32 wyldckat File Added: fixedTemperatureConstraint.H
2018-05-12 17:33 wyldckat File Added: typo.patch
2018-05-14 16:54 henry Status assigned => resolved
2018-05-14 16:54 henry Resolution open => fixed
2018-05-14 16:54 henry Fixed in Version => dev
2018-05-14 16:54 henry Note Added: 0009569