View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002431 | OpenFOAM | Patch | public | 2017-01-12 23:33 | 2017-01-13 14:24 |
| Reporter | wyldckat | Assigned To | henry | ||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Fixed in Version | dev | ||||
| Summary | 0002431: 'Cmu_' variable not used in realizableKE | ||||
| Description | My colleague Pedro Freitas, while checking for which parameters can be defined through dictionary files for the k-epsilon turbulence models, found that the variable 'Cmu_' is not used in realizableKE, given that the Realizable formulation uses its own dynamic Cmu calculation ('rCmu' function). Therefore, attached inside the package 'bugfix_2431_dev.tar.gz' are the two updated files without this unused parameter: - src/TurbulenceModels/turbulenceModels/RAS/realizableKE/realizableKE.H - src/TurbulenceModels/turbulenceModels/RAS/realizableKE/realizableKE.C Attached is also the patch file 'bugfix_2431_dev.patch' for easier inspection of the changes. | ||||
| Tags | No tags attached. | ||||
|
|
|
|
|
bugfix_2431_dev.patch (2,615 bytes)
diff --git a/src/TurbulenceModels/turbulenceModels/RAS/realizableKE/realizableKE.C b/src/TurbulenceModels/turbulenceModels/RAS/realizableKE/realizableKE.C
index a7ecf00..7257986 100644
--- a/src/TurbulenceModels/turbulenceModels/RAS/realizableKE/realizableKE.C
+++ b/src/TurbulenceModels/turbulenceModels/RAS/realizableKE/realizableKE.C
@@ -2,7 +2,7 @@
========= |
\\ / F ield | OpenFOAM: The Open Source CFD Toolbox
\\ / O peration |
- \\ / A nd | Copyright (C) 2011-2016 OpenFOAM Foundation
+ \\ / A nd | Copyright (C) 2011-2017 OpenFOAM Foundation
\\/ M anipulation |
-------------------------------------------------------------------------------
License
@@ -151,16 +151,6 @@ realizableKE<BasicTurbulenceModel>::realizableKE
transport,
propertiesName
),
-
- Cmu_
- (
- dimensioned<scalar>::lookupOrAddToDict
- (
- "Cmu",
- this->coeffDict_,
- 0.09
- )
- ),
A0_
(
dimensioned<scalar>::lookupOrAddToDict
@@ -240,7 +230,6 @@ bool realizableKE<BasicTurbulenceModel>::read()
{
if (eddyViscosity<RASModel<BasicTurbulenceModel>>::read())
{
- Cmu_.readIfPresent(this->coeffDict());
A0_.readIfPresent(this->coeffDict());
C2_.readIfPresent(this->coeffDict());
sigmak_.readIfPresent(this->coeffDict());
diff --git a/src/TurbulenceModels/turbulenceModels/RAS/realizableKE/realizableKE.H b/src/TurbulenceModels/turbulenceModels/RAS/realizableKE/realizableKE.H
index f47616f..9738b10 100644
--- a/src/TurbulenceModels/turbulenceModels/RAS/realizableKE/realizableKE.H
+++ b/src/TurbulenceModels/turbulenceModels/RAS/realizableKE/realizableKE.H
@@ -2,7 +2,7 @@
========= |
\\ / F ield | OpenFOAM: The Open Source CFD Toolbox
\\ / O peration |
- \\ / A nd | Copyright (C) 2011-2016 OpenFOAM Foundation
+ \\ / A nd | Copyright (C) 2011-2017 OpenFOAM Foundation
\\/ M anipulation |
-------------------------------------------------------------------------------
License
@@ -48,7 +48,6 @@ Description
\verbatim
realizableKECoeffs
{
- Cmu 0.09;
A0 4.0;
C2 1.9;
sigmak 1.0;
@@ -90,7 +89,6 @@ protected:
// Model coefficients
- dimensionedScalar Cmu_;
dimensionedScalar A0_;
dimensionedScalar C2_;
dimensionedScalar sigmak_;
|
|
|
I forgot to mention that this can be applied to both 4.x and dev. |
|
|
Resolved in OpenFOAM-dev by commit 78f6aebb992cac3d8cbd8e4ac90ca823d614e5b4 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-01-12 23:33 | wyldckat | New Issue | |
| 2017-01-12 23:33 | wyldckat | Status | new => assigned |
| 2017-01-12 23:33 | wyldckat | Assigned To | => henry |
| 2017-01-12 23:33 | wyldckat | File Added: bugfix_2431_dev.tar.gz | |
| 2017-01-12 23:33 | wyldckat | File Added: bugfix_2431_dev.patch | |
| 2017-01-12 23:34 | wyldckat | Note Added: 0007629 | |
| 2017-01-13 14:24 | henry | Status | assigned => resolved |
| 2017-01-13 14:24 | henry | Resolution | open => fixed |
| 2017-01-13 14:24 | henry | Fixed in Version | => dev |
| 2017-01-13 14:24 | henry | Note Added: 0007631 |
