View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002266OpenFOAMBugpublic2016-09-23 15:352016-09-25 18:40
ReporterMattijsJ Assigned Tohenry  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformGNU/LinuxOSOpenSuSEOS Version13.2
Product Versiondev 
Fixed in Versiondev 
Summary0002266: cellMotionFvPatchField does not preserve patchType
DescriptioncellMotionFvPatchField (and all others that construct the underlying type without the dictionary argument) do not set the 'patchType' and hence not preserve it.

These bcs do this because they are derived from fixedValue but do not need to read the value.

Probably want special fixedValue constructor that does not read the value.
TagsNo tags attached.

Activities

MattijsJ

2016-09-23 16:45

reporter  

fixedValue.patch (37,185 bytes)   

MattijsJ

2016-09-23 16:51

reporter   ~0006915

Above patch passes in a valueRequired flag into fixedValueFvPatchField.

The side effect is though that the value gets initialised to zero if valueRequired = false.

henry

2016-09-24 11:08

manager   ~0006916

There is a serious problem with this proposal:

A bunch of the tutorial cases fail, for example

LadenburgJet60psi:

--> FOAM FATAL IO ERROR:
compound has already been transfered from token
    on line 1277 the empty compound of type List<scalar>

file: /home/dm2/henry/OpenFOAM/OpenFOAM-dev/tutorials/compressible/rhoCentralFoam/LadenburgJet60psi/0/p.boundaryField.freestream.value at line 1277.

    From function Foam::token::compound &Foam::token::transferCompoundToken(const Foam::Istream &)
    in file lnInclude/token.C at line 99.

which is caused by


Foam::totalPressureFvPatchScalarField::totalPressureFvPatchScalarField
(
    const fvPatch& p,
    const DimensionedField<scalar, volMesh>& iF,
    const dictionary& dict
)
:
    fixedValueFvPatchScalarField(p, iF, dict, false), // *** NOTE: this read the value entry!
    UName_(dict.lookupOrDefault<word>("U", "U")),
    phiName_(dict.lookupOrDefault<word>("phi", "phi")),
    rhoName_(dict.lookupOrDefault<word>("rho", "rho")),
    psiName_(dict.lookupOrDefault<word>("psi", "none")),
    gamma_(psiName_ != "none" ? readScalar(dict.lookup("gamma")) : 1),
    p0_("p0", dict, p.size())
{
    if (dict.found("value")) // *** NOTE: WOOPS! reading the value entry again!
    {
        fvPatchField<scalar>::operator=
        (
            scalarField("value", dict, p.size())
        );
    }
    else
    {
        fvPatchField<scalar>::operator=(p0_);
    }
}

henry

2016-09-25 18:40

manager   ~0006920

Resolved by commits
4603a8b2539a68f252bdb2fc463696248062ff42
9d3f407fc7417455bae1c8ead90a08bb7c8293f8
25e5f67f8627ce4bd7b41ee3689a149a39bd057a

Issue History

Date Modified Username Field Change
2016-09-23 15:35 MattijsJ New Issue
2016-09-23 16:45 MattijsJ File Added: fixedValue.patch
2016-09-23 16:51 MattijsJ Note Added: 0006915
2016-09-24 11:08 henry Note Added: 0006916
2016-09-25 18:40 henry Assigned To => henry
2016-09-25 18:40 henry Status new => resolved
2016-09-25 18:40 henry Resolution open => fixed
2016-09-25 18:40 henry Fixed in Version => dev
2016-09-25 18:40 henry Note Added: 0006920