View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002264 | OpenFOAM | Bug | public | 2016-09-22 20:53 | 2016-09-22 23:05 |
| Reporter | wyldckat | Assigned To | henry | ||
| Priority | low | Severity | trivial | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Product Version | dev | ||||
| Fixed in Version | dev | ||||
| Summary | 0002264: Recent commit has a few old template definitions | ||||
| Description | I noticed in today's commit 7a52d2a5b with the message "globalMeshData: Revert NULL -> nullptr", fixed a small detail that was done in commit 521d7a4ae. Given that the message, I was curious and did a cursory glance at the commit 521d7a4ae and noticed a few "List<<T > >". A bit of find+grep: find src applications/ -name "*.[CH]" -type f | xargs grep " > >" found me the only file that had this older convention, namely in file "src/OpenFOAM/meshes/polyMesh/mapPolyMesh/mapDistribute/mapDistributeBaseTemplates.C" I then checked for "> >" and it found "src/thermophysicalModels/chemistryModel/chemistrySolver/chemistrySolver/makeChemistrySolverTypes.H". Sorry for not providing a patch in file form, but the following commands do the trick: sed -i -e 's= > >=>>=' src/OpenFOAM/meshes/polyMesh/mapPolyMesh/mapDistribute/mapDistributeBaseTemplates.C sed -i -e 's=> >=>>=' src/thermophysicalModels/chemistryModel/chemistrySolver/chemistrySolver/makeChemistrySolverTypes.H Nonetheless, this brings me to ask: In which script file should we have checks for these coding conventions? I know that the script "bin/tools/pre-commit-hook" will already do some of these checks, and I've used it with some success. But from past commits that I've seen, it doesn't seem to be always used, e.g. when the Copyright year is updated in another commit. | ||||
| Tags | No tags attached. | ||||
|
|
Thanks for picking this up, I didn't go through every line of the patch which was obviously based on an older version of OpenFOAM-dev. I have fixed the "> >" and will commit shortly. This code check could be added to pre-commit-hook as well as NULL -> nullptr. |
|
|
Resolved by commit c169ca14f5152e37d4701cbb5c1191743e310c02 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-09-22 20:53 | wyldckat | New Issue | |
| 2016-09-22 20:53 | wyldckat | Status | new => assigned |
| 2016-09-22 20:53 | wyldckat | Assigned To | => henry |
| 2016-09-22 21:03 | henry | Note Added: 0006908 | |
| 2016-09-22 23:05 | henry | Status | assigned => resolved |
| 2016-09-22 23:05 | henry | Resolution | open => fixed |
| 2016-09-22 23:05 | henry | Fixed in Version | => dev |
| 2016-09-22 23:05 | henry | Note Added: 0006909 |
