View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002218 | OpenFOAM | Patch | public | 2016-08-25 01:17 | 2016-08-25 08:28 |
Reporter | wyldckat | Assigned To | henry | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | dev | ||||
Fixed in Version | dev | ||||
Summary | 0002218: src/Pstream/Allwclean is missing, leading to not properly clean up the respective MPI build of Pstream | ||||
Description | Given that 'WM_OPTIONS="$WM_OPTIONS$WM_MPLIB"' use used for building the MPI-dependent version of Pstream, running "wclean all" will not pick up on this automatically. Attached is the file "Allwclean" for the folder "src/Pstream". This is needed for when the user wants to ensure that the respective intermediate files for the MPI-dependent library is properly cleaned up, even though "Allwmake" already cleans up as a counter-measure before building. | ||||
Additional Information | I picked up on this after reviewing report #2204. Nonetheless, this does raise the question: Shouldn't these kinds of libraries have an easier and self-sustained way of building/cleaning up, without having to fully rely on an "Allw*" script in the parent folder? | ||||
Tags | No tags attached. | ||||
|
Allwclean (475 bytes)
#!/bin/sh cd ${0%/*} || exit 1 # Run from this directory # # define how to an mpi-versioned library is created # clean the qualified directory # wcleanMpiLib() { set +x for libName do ( WM_OPTIONS="$WM_OPTIONS$WM_MPLIB" wclean $libName ) done set -x } set -x wclean dummy case "$WM_MPLIB" in *MPI*) set +x wcleanMpiLib mpi ;; esac #------------------------------------------------------------------------------ |
|
I was reviewing the file "wmake/makefiles/general" to see how to have a self-sustained build of these libraries and I spotted this typo: diff --git a/wmake/makefiles/general b/wmake/makefiles/general index b9a4f99..b7f4935 100644 --- a/wmake/makefiles/general +++ b/wmake/makefiles/general @@ -100,7 +100,7 @@ include $(GENERAL_RULES)/general #------------------------------------------------------------------------------ # Include PROJECT directory tree file and # source, object and dependency list files. -# These are constructed by MakefileFiles +# These are constructed by makefiles/files #------------------------------------------------------------------------------ include $(OBJECTS_DIR)/options |
|
Thanks Bruno. Incidentally "These are constructed by MakefileFiles" is not a typo but legacy: 'MakefileFiles' is what the file 'makefiles/files' used to be named. An error nevertheless. Resolved by commit 71a646e63c6f8c8a6eb81bb07a953ac92ebb4158 |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-08-25 01:17 | wyldckat | New Issue | |
2016-08-25 01:17 | wyldckat | Status | new => assigned |
2016-08-25 01:17 | wyldckat | Assigned To | => henry |
2016-08-25 01:17 | wyldckat | File Added: Allwclean | |
2016-08-25 01:27 | wyldckat | Note Added: 0006763 | |
2016-08-25 08:28 | henry | Note Added: 0006767 | |
2016-08-25 08:28 | henry | Status | assigned => resolved |
2016-08-25 08:28 | henry | Fixed in Version | => dev |
2016-08-25 08:28 | henry | Resolution | open => fixed |