View Issue Details

IDProjectCategoryView StatusLast Update
0002169OpenFOAMPatchpublic2016-08-01 20:59
ReporterwyldckatAssigned Tohenry 
PrioritylowSeveritytrivialReproducibilityN/A
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0002169: Duplicate entry in EXE_INC of dynamicMesh in foamToEnsight/Make/options
DescriptionNot a critical issue, but as shown in the "Additional Information" below, there is a duplicate entry of the path dynamicMesh in "foamToEnsight/Make/options", for which the attached file has this sorted out.
Additional Information applications/utilities/postProcessing/dataConversion/foamToEnsight/Make/options
index 18bbc7a..62cdf11 100644
@@ -4,7 +4,6 @@ EXE_INC = \
     -I$(LIB_SRC)/meshTools/lnInclude \
     -I$(LIB_SRC)/dynamicMesh/lnInclude \
     -I$(LIB_SRC)/sampling/lnInclude \
- -I$(LIB_SRC)/dynamicMesh/lnInclude \
     -I$(LIB_SRC)/lagrangian/basic/lnInclude
 
 EXE_LIBS = \
TagsNo tags attached.

Activities

wyldckat

2016-08-01 18:23

updater  

options (343 bytes)
EXE_INC = \
    /* -DFULLDEBUG -g -O0 */ \
    -I$(LIB_SRC)/finiteVolume/lnInclude \
    -I$(LIB_SRC)/meshTools/lnInclude \
    -I$(LIB_SRC)/dynamicMesh/lnInclude \
    -I$(LIB_SRC)/sampling/lnInclude \
    -I$(LIB_SRC)/lagrangian/basic/lnInclude

EXE_LIBS = \
    -ldynamicMesh \
    -lsampling \
    -lgenericPatchFields \
    -llagrangian

options (343 bytes)

wyldckat

2016-08-01 18:25

updater   ~0006597

Sorry, forgot to mention that this also applies to OpenFOAM-dev.

wyldckat

2016-08-01 18:44

updater  

checkOptionsForDuplicateFiles (310 bytes)
#!/bin/sh

echo "Processing folders: $FOAM_SRC $FOAM_APP"

find $FOAM_SRC $FOAM_APP -name options -type f | while read item
do
    if [ $(grep -v '^$' $item | wc -l) -ne $(grep -v '^$' $item | sort -u | wc -l) ]
    then
        echo "File with duplicate lines: $item"
    fi
done

echo "Processing complete."

wyldckat

2016-08-01 18:47

updater   ~0006598

Attached is the script "checkOptionsForDuplicateFiles", which should assist in catching future duplicates, although there might provide false-positives in some scenarios.

The following files were caught with this script:

  src/thermophysicalModels/solidChemistryModel/Make/options
  applications/solvers/multiphase/twoPhaseEulerFoam/Make/options
  applications/solvers/multiphase/reactingEulerFoam/interfacialCompositionModels/Make/options
  applications/solvers/multiphase/multiphaseEulerFoam/Make/options
  applications/solvers/compressible/rhoPimpleFoam/rhoPimpleDyMFoam/Make/options
  applications/solvers/compressible/sonicFoam/sonicDyMFoam/Make/options
  applications/solvers/compressible/sonicFoam/Make/options
  applications/solvers/combustion/fireFoam/Make/options
  applications/utilities/postProcessing/dataConversion/foamToEnsight/Make/options
  applications/utilities/postProcessing/postProcess/Make/options
  applications/utilities/preProcessing/viewFactorsGen/Make/options

henry

2016-08-01 20:59

manager   ~0006604

Thanks for the script Bruno, I used it to help update 4.x and dev:

Resolved in OpenFOAM-4.x by commit 57de5138dd4fd89c01142f43a2c92b6bd82aca21
Resolved in OpenFOAM-dev by commit 6f82d23d17015e9f067480c2b12acf213ac1228a

Issue History

Date Modified Username Field Change
2016-08-01 18:23 wyldckat New Issue
2016-08-01 18:23 wyldckat Status new => assigned
2016-08-01 18:23 wyldckat Assigned To => henry
2016-08-01 18:23 wyldckat File Added: options
2016-08-01 18:25 wyldckat Note Added: 0006597
2016-08-01 18:44 wyldckat File Added: checkOptionsForDuplicateFiles
2016-08-01 18:47 wyldckat Note Added: 0006598
2016-08-01 20:59 henry Note Added: 0006604
2016-08-01 20:59 henry Status assigned => resolved
2016-08-01 20:59 henry Fixed in Version => 4.x
2016-08-01 20:59 henry Resolution open => fixed