View Issue Details

IDProjectCategoryView StatusLast Update
0002034ThirdParty[All Projects] Bugpublic2016-03-30 19:30
ReporterwyldckatAssigned Tohenry 
PrioritylowSeveritytweakReproducibilitysometimes
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0002034: Proposed environment override for isolating ParaView's ".git" lookup
DescriptionIn issue #1986 was somewhat reported and a partial fix was done for a problem where the script "CMake/ParaViewDetermineVersion.cmake" in at least ParaView 4.4 and 5.0 will pick-up by mistake the version number "3.0", which lead to installing ParaView's builds at the folders "ParaView-*/*/paraview-3.0".

The reason why this happens is because in the "ThirdParty-dev" repository is the tag "version-3.0.0": https://github.com/OpenFOAM/ThirdParty-dev/tree/version-3.0.0
This occurs because the command "git describe" is used to collect from this tag for the version information, which will in turn report something like this:

  version-3.0.0-10-gd88b4ea

After some researching into how Git provides the ability to isolate paths, my search ended at the manual for "git config": https://git-scm.com/docs/git-config.html - where "core.worktree" mentions a few overriding environment variables and "GIT_DIR" in specific can be used to block this issue from ever happening again... as long as we use the "makeParaView*" scripts.

Attached are the following packages:

  - ParaView_Function_updates.tar.gz - Meant to be unpacked in the directory "ThirdParty-dev" and provides the simple fix for the files "etc/tools/ParaView*Functions", namely to run the following command at the end of the function "setDirs()":

       export GIT_DIR=$ParaView_SOURCE_DIR/.git


  - paraview_shell_updates.tar.gz - Meant for the directory "OpenFOAM-dev", which updates the files "etc/config.*/paraview" to no longer use the replacement folder "paraview-3.0" if found.


The first package can be deployed straight away in ThirdParty-dev; but I'm not certain when the second package should be deployed in OpenFOAM-dev, even though it's the development branch, which is in constant evolution.
TagsNo tags attached.

Relationships

related to 0001986 closedhenry ParaView 4.4.0 (and 5.0.0) fails to detect source code version 

Activities

wyldckat

2016-03-27 20:22

updater  

ParaView_Function_updates.tar.gz (4,638 bytes)

wyldckat

2016-03-27 20:23

updater  

paraview_shell_updates.tar.gz (2,353 bytes)

henry

2016-03-30 19:30

manager   ~0006066

Thanks for sorting this out Bruno.

Resolved in OpenFOAM-dev by commit c7179bd0d08d183f4f2a9d0b9af1df3e84d12ca2
Resolved in ThirdParty-dev by commit 8c9c235db686de2612c62112b37e132bfa773b16

Issue History

Date Modified Username Field Change
2016-03-27 20:22 wyldckat New Issue
2016-03-27 20:22 wyldckat Status new => assigned
2016-03-27 20:22 wyldckat Assigned To => henry
2016-03-27 20:22 wyldckat File Added: ParaView_Function_updates.tar.gz
2016-03-27 20:23 wyldckat File Added: paraview_shell_updates.tar.gz
2016-03-27 20:23 wyldckat Relationship added related to 0001986
2016-03-30 19:30 henry Note Added: 0006066
2016-03-30 19:30 henry Status assigned => resolved
2016-03-30 19:30 henry Resolution open => fixed