View Issue Details

IDProjectCategoryView StatusLast Update
0001285OpenFOAM[All Projects] Bugpublic2014-12-18 12:37
ReporterdkxlsAssigned Tohenry 
PrioritynormalSeveritytextReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinux x86_64OSopenSUSEOS Version12.3
Product Version 
Fixed in Version 
Summary0001285: [ReactingParcel]: Missleading description for mass0()
DescriptionThe description for mass0() in the ReactingParcel class is not clear. See attached patch for a correct description.
Additional InformationA clear description would help to avoid bugs, see my other reports.
TagsLagrangian

Activities

dkxls

2014-05-10 14:47

reporter  

0001-lagrangian-ReactingParcel-Correct-description-for-ma.patch (902 bytes)
diff --git a/src/lagrangian/intermediate/parcels/Templates/ReactingParcel/ReactingParcel.H b/src/lagrangian/intermediate/parcels/Templates/ReactingParcel/ReactingParcel.H
index aea3732..535d28d 100644
--- a/src/lagrangian/intermediate/parcels/Templates/ReactingParcel/ReactingParcel.H
+++ b/src/lagrangian/intermediate/parcels/Templates/ReactingParcel/ReactingParcel.H
@@ -337,7 +337,7 @@ public:

         // Access

-            //- Return const access to initial mass
+            //- Return const access to initial particle mass
             inline scalar mass0() const;

             //- Return const access to mass fractions of mixture
@@ -352,7 +352,7 @@ public:

         // Edit

-            //- Return access to initial mass
+            //- Return access to initial particle mass
             inline scalar& mass0();

             //- Return access to mass fractions of mixture
--
1.8.1.4

dkxls

2014-12-17 16:19

reporter   ~0003329

This bug is still present in 2.3.1!

henry

2014-12-18 12:37

manager   ~0003334

Resolved by commit e137f8f9672f8e17c1f16f6b22e607342ebb22ac

Issue History

Date Modified Username Field Change
2014-05-10 14:47 dkxls New Issue
2014-05-10 14:47 dkxls File Added: 0001-lagrangian-ReactingParcel-Correct-description-for-ma.patch
2014-06-11 16:09 dkxls Tag Attached: Lagrangian
2014-12-17 16:19 dkxls Note Added: 0003329
2014-12-18 12:37 henry Note Added: 0003334
2014-12-18 12:37 henry Status new => resolved
2014-12-18 12:37 henry Resolution open => fixed
2014-12-18 12:37 henry Assigned To => henry