View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001204OpenFOAMBugpublic2014-03-03 12:222014-03-03 19:22
Reportertniemi Assigned Tohenry  
PrioritynormalSeveritytrivialReproducibilityalways
Status resolvedResolutionfixed 
Summary0001204: TwoPhaseEulerFoam, Schaeffer frictional stress, phi not converted to degrees
DescriptionIn twoPhaseEulerFoam, the Schaeffer frictional stress model doesn't convert the angle of internal friction (phi-parameter) to degrees, while the JohnsonJackson model does. I think this is a bit confusing and it would be better if both models used degrees. (the same behavior as in 2.2)
TagsNo tags attached.

Activities

albertop

2014-03-03 15:14

reporter   ~0002923

Indeed the conversion

phi_ *= constant::mathematical::pi/180;

should be also in the constructor of Schaeffer's model. :)

henry

2014-03-03 19:21

manager   ~0002924

Resolved by commit 3827b4ad60e021667c57172e1b139a38bb4277c8

Issue History

Date Modified Username Field Change
2014-03-03 12:22 tniemi New Issue
2014-03-03 15:14 albertop Note Added: 0002923
2014-03-03 19:21 henry Note Added: 0002924
2014-03-03 19:21 henry Status new => resolved
2014-03-03 19:21 henry Resolution open => fixed
2014-03-03 19:21 henry Assigned To => henry