View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001053OpenFOAMBugpublic2013-10-18 07:322013-12-02 12:42
ReporterSahas Assigned Touser21 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Summary0001053: Wrong smoothing in viewFactor radiation model
DescriptionIn file src/thermophysicalModels/radiationModels/radiationModel/viewFactor/viewFactor.C wrong sign when multiplying matrix by smoothing factor.
Now:
Fmatrix_()[i][j] *= (1.0 - delta/(sumF + 0.001));
Should be:
Fmatrix_()[i][j] *= (1.0 + delta/(sumF + 0.001));

Patch is attached.
Steps To ReproduceThere is the test case. It is a box with opposite walls under equal big temperature 1500K. I use chtMultiRegionFoam solver.
There are 3 runs: without smoothing, with wrong smoothing and with right smoothing.
The results (Qr on the patches wall_heat and wall_opposite):
no smoothing: -5.3E+5 < Qr < -2.8E+5
smoothing wrong: -3.2E+5 < Qr < -2E+5
smoothing right: 250 < Qr < 550
TagsNo tags attached.

Activities

Sahas

2013-10-18 07:32

reporter  

fix_smoothing_rad_viewFactor.diff (754 bytes)    
diff --git a/src/thermophysicalModels/radiationModels/radiationModel/viewFactor/viewFactor.C b/src/thermophysicalModels/radiationModels/radiationModel/viewFactor/viewFactor.C
index 6e45cbb..4451d8a 100644
--- a/src/thermophysicalModels/radiationModels/radiationModel/viewFactor/viewFactor.C
+++ b/src/thermophysicalModels/radiationModels/radiationModel/viewFactor/viewFactor.C
@@ -203,7 +203,7 @@ void Foam::radiation::viewFactor::initialise()
                 scalar delta = 1.0 - sumF;
                 for (label j=0; j<totalNCoarseFaces_; j++)
                 {
-                    Fmatrix_()[i][j] *= (1.0 - delta/(sumF + 0.001));
+                    Fmatrix_()[i][j] *= (1.0 + delta/(sumF + 0.001));
                 }
             }
         }
fix_smoothing_rad_viewFactor.diff (754 bytes)   

Sahas

2013-10-18 07:35

reporter  

box_test.tar.gz (256,308 bytes)

user21

2013-12-02 12:41

  ~0002672

Thanks for the report. Problem solved in commit

58e25f034888c01330cf01eb5e88e791998e243f

http://www.openfoam.org/mantisbt/view.php?id=1053

Regards

Issue History

Date Modified Username Field Change
2013-10-18 07:32 Sahas New Issue
2013-10-18 07:32 Sahas File Added: fix_smoothing_rad_viewFactor.diff
2013-10-18 07:35 Sahas File Added: box_test.tar.gz
2013-12-02 12:41 user21 Note Added: 0002672
2013-12-02 12:41 user21 Status new => resolved
2013-12-02 12:41 user21 Resolution open => fixed
2013-12-02 12:41 user21 Assigned To => user21