View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000105 | OpenFOAM | Bug | public | 2010-12-11 05:40 | 2010-12-13 10:35 |
| Reporter | Assigned To | ||||
| Priority | normal | Severity | major | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000105: Wrong REPEAT bounds handling in case of underflow in interpolationTable | ||||
| Description | In the case of underflow with REPEAT bounds handling the interpolation point is increased by the maximum value until it is >= 0 instead of >= minimum value. In case of overflow the handling is correct. | ||||
| Additional Information | Attached patch fixes this. | ||||
| Tags | No tags attached. | ||||
|
2010-12-11 05:40
|
0001-FIX-underflow-REPEAT-handling-in-interpolationTable.patch (1,123 bytes)
From c6c9cb89b6687ed9960cbd3c0fb0b29ce1dff0d4 Mon Sep 17 00:00:00 2001
From: Michael Wild <themiwi@users.sourceforge.net>
Date: Sat, 11 Dec 2010 06:38:47 +0100
Subject: [PATCH] FIX: underflow REPEAT handling in interpolationTable
Signed-off-by: Michael Wild <themiwi@users.sourceforge.net>
---
.../interpolationTable/interpolationTable.C | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/OpenFOAM/interpolations/interpolationTable/interpolationTable.C b/src/OpenFOAM/interpolations/interpolationTable/interpolationTable.C
index 2bdf04c..a59f703 100644
--- a/src/OpenFOAM/interpolations/interpolationTable/interpolationTable.C
+++ b/src/OpenFOAM/interpolations/interpolationTable/interpolationTable.C
@@ -381,7 +381,7 @@ Type Foam::interpolationTable<Type>::operator()(const scalar value) const
case interpolationTable::REPEAT:
{
// adjust lookupValue to >= 0
- while (lookupValue < 0)
+ while (lookupValue < minLimit)
{
lookupValue += maxLimit;
}
--
1.7.1
|
|
|
2dcf8751b980bb7c1bbffd7ce1c00438ee2d4c96 Thanks for fix. I've changed it to use modulo arithmetic. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-12-11 05:40 |
|
New Issue | |
| 2010-12-11 05:40 |
|
File Added: 0001-FIX-underflow-REPEAT-handling-in-interpolationTable.patch | |
| 2010-12-13 10:35 |
|
Note Added: 0000175 | |
| 2010-12-13 10:35 |
|
Status | new => resolved |
| 2010-12-13 10:35 |
|
Fixed in Version | => 1.7.x |
| 2010-12-13 10:35 |
|
Resolution | open => fixed |
| 2010-12-13 10:35 |
|
Assigned To | => user4 |
