View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003647 | OpenFOAM | Patch | public | 2021-03-24 08:48 | 2021-03-24 11:11 |
| Reporter | Juho | Assigned To | will | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | GNU/Linux | OS | Other | OS Version | (please specify) |
| Product Version | dev | ||||
| Fixed in Version | dev | ||||
| Summary | 0003647: multiphaseEulerFoam: linearTsub diameterModel does not find the saturationModels | ||||
| Description | linearTsub diameterModel still has the old style global saturation model lookup instead of the phase pair specific saturation models used currently. Thus, the saturationModel is not found and diameter is not updated during the simulations. Modified linearTsubDiameter attached. Changes: - Updated to use the current phase pair specific saturation models. - Changed subcooling sign convention to to be compatible with the default parameters - Added default values to the read function as well - Print selected parameters to log | ||||
| Tags | No tags attached. | ||||
|
|
linearTsubDiameter.C (4,884 bytes) |
|
|
Thanks for the patch, Juho. Small suggestion. Is it possible to use the phase system's lookup instead? It would save doing the name manipulations manually. E.g.: if (phase().fluid().foundSubModel<saturationModel>(pair)) { const saturationModel& satModel = phase().fluid().lookupSubModel<saturationModel>(pair); ... } I'd try it myself, but I don't have a test case with this model active. I assume you do. |
|
|
Updated file attached. Much neater this way. linearTsubDiameter-2.C (4,684 bytes) |
|
|
Thanks for that. Pushed as commit https://github.com/OpenFOAM/OpenFOAM-dev/commit/42a558a1b0596896a244ce0489545421aa6260bf |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-03-24 08:48 | Juho | New Issue | |
| 2021-03-24 08:48 | Juho | File Added: linearTsubDiameter.C | |
| 2021-03-24 09:20 | will | Note Added: 0011951 | |
| 2021-03-24 09:43 | Juho | File Added: linearTsubDiameter-2.C | |
| 2021-03-24 09:43 | Juho | Note Added: 0011952 | |
| 2021-03-24 11:11 | will | Assigned To | => will |
| 2021-03-24 11:11 | will | Status | new => resolved |
| 2021-03-24 11:11 | will | Resolution | open => fixed |
| 2021-03-24 11:11 | will | Fixed in Version | => dev |
| 2021-03-24 11:11 | will | Note Added: 0011953 |
