View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003554 | OpenFOAM | Patch | public | 2020-09-23 10:29 | 2020-09-29 15:16 |
| Reporter | wyldckat | Assigned To | will | ||
| Priority | normal | Severity | minor | Reproducibility | sometimes |
| Status | resolved | Resolution | fixed | ||
| Product Version | 8 | ||||
| Fixed in Version | 8 | ||||
| Summary | 0003554: semiPermeableBaffleMassFraction includes a declaration of 'composition(...)' but not the definition | ||||
| Description | In the file 'src/specieTransfer/derivedFvPatchFields/semiPermeableBaffleMassFraction/semiPermeableBaffleMassFractionFvPatchScalarField.H' is declared: static const basicSpecieMixture& composition(const objectRegistry& db); But it's not defined in the '.C' file what it does. It looks like there was a bit of an incomplete copy-paste from the class 'specieTransferMassFractionFvPatchScalarField' from which 'semiPermeableBaffleMassFractionFvPatchScalarField' inherits from, but this static method seems to be simple enough to not require a redefinition. Attached is the proposed patch 'proposed_fix_v1.patch' and the respective updated file, namely to remove the declaration from said file. | ||||
| Additional Information | Found this when compiling on Windows with MSys2 + GCC 10.2. | ||||
| Tags | No tags attached. | ||||
|
|
proposed_fix_v1.patch (890 bytes)
semiPermeableBaffleMassFractionFvPatchScalarField.H (6,727 bytes)diff --git a/src/specieTransfer/derivedFvPatchFields/semiPermeableBaffleMassFraction/semiPermeableBaffleMassFractionFvPatchScalarField.H b/src/specieTransfer/derivedFvPatchFields/semiPermeableBaffleMassFraction/semiPermeableBaffleMassFractionFvPatchScalarField.H
index d1a033d..2324f5d 100644
--- a/src/specieTransfer/derivedFvPatchFields/semiPermeableBaffleMassFraction/semiPermeableBaffleMassFractionFvPatchScalarField.H
+++ b/src/specieTransfer/derivedFvPatchFields/semiPermeableBaffleMassFraction/semiPermeableBaffleMassFractionFvPatchScalarField.H
@@ -110,12 +110,6 @@ public:
TypeName("semiPermeableBaffleMassFraction");
- // Static member functions
-
- //- Access the composition for the given database
- static const basicSpecieMixture& composition(const objectRegistry& db);
-
-
// Constructors
//- Construct from patch and internal field
|
|
|
I forgot to mention that this is applicable to OpenFOAM 8 and dev. |
|
|
Thanks for the report. Fixed in 8 and dev. https://github.com/OpenFOAM/OpenFOAM-8/commit/a3389546b5b598cf4065b0729b2b4df8b12eeecd https://github.com/OpenFOAM/OpenFOAM-dev/commit/b0d91b53a70ef8a3450abbfe6a6ad53073ed4815 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-09-23 10:29 | wyldckat | New Issue | |
| 2020-09-23 10:29 | wyldckat | Status | new => assigned |
| 2020-09-23 10:29 | wyldckat | Assigned To | => henry |
| 2020-09-23 10:29 | wyldckat | File Added: proposed_fix_v1.patch | |
| 2020-09-23 10:29 | wyldckat | File Added: semiPermeableBaffleMassFractionFvPatchScalarField.H | |
| 2020-09-23 10:29 | wyldckat | Note Added: 0011521 | |
| 2020-09-29 15:16 | will | Assigned To | henry => will |
| 2020-09-29 15:16 | will | Status | assigned => resolved |
| 2020-09-29 15:16 | will | Resolution | open => fixed |
| 2020-09-29 15:16 | will | Fixed in Version | => 8 |
| 2020-09-29 15:16 | will | Note Added: 0011551 |
