#### View Issue Details

ID Project Category View Status Date Submitted Last Update 0003102 OpenFOAM Bug public 2018-11-07 14:31 2018-11-14 15:40 DanielJ henry normal minor always resolved fixed dev 0003102: Inconsistent behavior of fanFvPatchField fanFvPatchField is derived from uniformJumpFvPatchField and has different specialization for different field types. For scalars, it computes jump value based on the local(!!!) normal velocity, for all other types the jump is computed based on the current time. Why is this a problem:  - very different behavior for different types violates the "principle of least astonishment"  - for types other than scalar, the behavior of the BC exactly duplicates the behavior of the uniformJumpFvPatchField  - pressure jump based on the local velocity is not convenient, if at all reasonable, and inconsistent with fanPressure BC which defines fan pressure as a function of the volumetric flow rate  - "jumpTable" keyword from base class is used to describe the fan characteristics, which is not very domain-related and therefore the semantics of this field is not obvious Change proposal:  - de-templatize fanFvPatchField and create only scalar version  - derive implementation from fixedJumpFvPatchField not uniformJumpFvPatchField  - add Function1 field, describing pressure as a function of flow rate, with more domain specific name like "fanCurve"  - deprecate with warning the previous field "jumpTable", but preserve backward compatible behavior Optional:  - allow for reversing the "direction" of the pressure jump without the need to change fan curve I can make the necessary changes if approved. No tags attached.

#### Issue History

2018-11-07 14:31 DanielJ New Issue
2018-11-07 14:53 henry Note Added: 0010153
2018-11-07 16:07 DanielJ Note Added: 0010155
2018-11-07 16:33 henry Note Added: 0010156
2018-11-07 16:42 DanielJ Note Added: 0010157
2018-11-07 16:53 henry Note Added: 0010158
2018-11-07 17:19 DanielJ Note Added: 0010159
2018-11-08 06:18 DanielJ File Added: fanPressureJump.patch
2018-11-08 06:18 DanielJ Note Added: 0010166
2018-11-14 15:40 henry Assigned To => henry
2018-11-14 15:40 henry Status new => resolved
2018-11-14 15:40 henry Resolution open => fixed
2018-11-14 15:40 henry Fixed in Version => dev
2018-11-14 15:40 henry Note Added: 0010185