View Issue Details

IDProjectCategoryView StatusLast Update
0002303OpenFOAMPatchpublic2016-10-25 18:37
ReporterMattijsJ Assigned Tohenry  
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformGNU/LinuxOSOpenSuSEOS Version13.2
Product Versiondev 
Fixed in Versiondev 
Summary0002303: chtMultiRegionFoam reports incorrect diffusion number
DescriptionDiffusion number gets calculated over internal faces only. Attached patch to enforce calculation over boundaryFields as well.
TagsNo tags attached.

Activities

MattijsJ

2016-10-21 12:47

reporter  

solidRegionDiffNo.C (2,059 bytes)   
/*---------------------------------------------------------------------------*\
  =========                 |
  \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
   \\    /   O peration     |
    \\  /    A nd           | Copyright (C) 2011-2016 OpenFOAM Foundation
     \\/     M anipulation  |
-------------------------------------------------------------------------------
License
    This file is part of OpenFOAM.

    OpenFOAM is free software: you can redistribute it and/or modify it
    under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    OpenFOAM is distributed in the hope that it will be useful, but WITHOUT
    ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    for more details.

    You should have received a copy of the GNU General Public License
    along with OpenFOAM.  If not, see <http://www.gnu.org/licenses/>.

\*---------------------------------------------------------------------------*/

#include "solidRegionDiffNo.H"
#include "fvc.H"

Foam::scalar Foam::solidRegionDiffNo
(
    const fvMesh& mesh,
    const Time& runTime,
    const volScalarField& Cprho,
    const volScalarField& kappa
)
{
    scalar DiNum = 0.0;
    scalar meanDiNum = 0.0;

    //- Take care: can have fluid domains with 0 cells so do not test for
    //  zero internal faces.
    surfaceScalarField kapparhoCpbyDelta
    (
        mesh.surfaceInterpolation::deltaCoeffs()
      * fvc::interpolate(kappa)
      / fvc::interpolate(Cprho)
    );
 
    DiNum = max(kapparhoCpbyDelta).value()*runTime.deltaT().value();

    meanDiNum = (average(kapparhoCpbyDelta)).value()*runTime.deltaT().value();

    Info<< "Region: " << mesh.name() << " Diffusion Number mean: " << meanDiNum
        << " max: " << DiNum << endl;

    return DiNum;
}

// ************************************************************************* //
solidRegionDiffNo.C (2,059 bytes)   

henry

2016-10-25 18:37

manager   ~0007067

Resolved by commit fe7c8b7d4ea416d5748c50d7c3ea5d59512e3401

Issue History

Date Modified Username Field Change
2016-10-21 12:47 MattijsJ New Issue
2016-10-21 12:47 MattijsJ File Added: solidRegionDiffNo.C
2016-10-25 18:37 henry Assigned To => henry
2016-10-25 18:37 henry Status new => resolved
2016-10-25 18:37 henry Resolution open => fixed
2016-10-25 18:37 henry Fixed in Version => dev
2016-10-25 18:37 henry Note Added: 0007067