View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002152 | OpenFOAM | Patch | public | 2016-07-15 11:16 | 2016-07-15 11:46 |
| Reporter | wyldckat | Assigned To | henry | ||
| Priority | normal | Severity | major | Reproducibility | sometimes |
| Status | resolved | Resolution | fixed | ||
| Product Version | dev | ||||
| Fixed in Version | dev | ||||
| Summary | 0002152: "uint.H" has an inconsistent definition, when cross-checking with "uintIO.C" | ||||
| Description | The file "src/OpenFOAM/primitives/ints/uint/uint.H" has this declaration: uint readUint(Istream&); while "uintIO.C" defines it as: unsigned int Foam::readUint(Istream& is) This is an inconsistency, given that some systems will either not have a definition for "uint" or may have another different definition from "unsigned int". Attached is the file that fixes this in "uint.H", by using "unsigned int" instead of "uint". | ||||
| Additional Information | This is a bit bias on my part, given that I'm currently working on porting the OpenFOAM-dev master branch to Windows and "uint" is undefined with the standard definitions that are inherited from "uint32.H" in the current stack that I'm using. Nonetheless, an explicit usage of "unsigned int" makes a bit more sense, in case there are more systems that simply don't have "uint" defined or have a simply have a different definition. | ||||
| Tags | No tags attached. | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-07-15 11:16 | wyldckat | New Issue | |
| 2016-07-15 11:16 | wyldckat | Status | new => assigned |
| 2016-07-15 11:16 | wyldckat | Assigned To | => henry |
| 2016-07-15 11:16 | wyldckat | File Added: uint.H | |
| 2016-07-15 11:46 | henry | Note Added: 0006531 | |
| 2016-07-15 11:46 | henry | Status | assigned => resolved |
| 2016-07-15 11:46 | henry | Fixed in Version | => dev |
| 2016-07-15 11:46 | henry | Resolution | open => fixed |
