View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001143||OpenFOAM||[All Projects] Bug||public||2014-01-29 16:28||2015-02-14 22:33|
|Fixed in Version|
|Summary||0001143: wrong index passed to constructor of polyMeshModifier in polyTopoChanger::readModifiers()|
|Description||in line 67 and following of dynamicMesh/polyTopoChange/polyTopoChanger/polyTopoChanger.C:|
in modifiers.set(....) the index of the modifier in the polyTopoChanger, modifierI, is passed to polyMeshModifier::New, however, the index of the corresponding patch in the boundaryMesh should be passed to the constructor.
|Tags||No tags attached.|
|The individual polyMeshModifiers get constructed with their index into the overall list of modifiers. (this is similar to the way polyPatches or zones get constructed).|
from the source code documentation, however, it says this:
label index ( ) const
Return the index of this patch in the boundaryMesh.
Definition at line 150 of file polyMeshModifier.H.
This was misleading me. Actually I see now its about the faceZone index,whihc is not necessarily the same as the patch index in the boundary mesh.
Perhaps the documentation text should be changed?
I can confirm tehache's latest comment, where in the file "dynamicMesh/polyTopoChange/polyMeshModifier/polyMeshModifier.H", there is this description for the variables:
// Private data
//- Name of zone
//- Index of zone
But then for the method it wrongly refers to a patch index, instead of zone index:
//- Return the index of this patch in the boundaryMesh
label index() const
After using "grep" for looking for other similar occurrences, my guess is that this comment was inherited after a copy-paste from here: "OpenFOAM/meshes/Identifiers/patch/patchIdentifier.H" ;)
||Roselved by commit ac39cc30159cc07331d661a71795b3ae8faa4d54|
||Note Added: 0002789|
||Note Added: 0002793|
|2015-02-14 22:10||wyldckat||Note Added: 0003776|
|2015-02-14 22:33||henry||Note Added: 0003778|
|2015-02-14 22:33||henry||Status||new => resolved|
|2015-02-14 22:33||henry||Resolution||open => fixed|
|2015-02-14 22:33||henry||Assigned To||=> henry|