View Issue Details

IDProjectCategoryView StatusLast Update
0003938OpenFOAMBugpublic2022-11-29 14:36
Reportercgoessni Assigned Tohenry  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Versiondev 
Fixed in Versiondev 
Summary0003938: timeActivatedFileUpdate: missing timeToUserTime conversion
DescriptiontimeActivatedFileUpdate is missing a timeToUserTime conversion.

Additionally, the time check might be better if "<=" was used, since with the current version "<", the file update would be one time step too late.

Proposed diff attached.
TagsNo tags attached.

Activities

cgoessni

2022-11-29 06:58

reporter  

diff_timeActivatedFileUpdate.txt (650 bytes)   
diff --git a/src/functionObjects/utilities/timeActivatedFileUpdate/timeActivatedFileUpdate.C b/src/functionObjects/utilities/timeActivatedFileUpdate/timeActivatedFileUpdate.C
index c8e3847..bdbccf6 100644
--- a/src/functionObjects/utilities/timeActivatedFileUpdate/timeActivatedFileUpdate.C
+++ b/src/functionObjects/utilities/timeActivatedFileUpdate/timeActivatedFileUpdate.C
@@ -54,7 +54,7 @@ void Foam::functionObjects::timeActivatedFileUpdate::updateFile()
     while
     (
         i < timeVsFile_.size()-1
-     && timeVsFile_[i+1].first() < time_.value()
+     && timeVsFile_[i+1].first() <= time_.userTimeValue()
     )
     {
         i++;

henry

2022-11-29 14:36

manager   ~0012902

Thanks for reporting.
Resolved by commit 303c0167045dcd13905abbebaa4c52fc5d912ceb

Issue History

Date Modified Username Field Change
2022-11-29 06:58 cgoessni New Issue
2022-11-29 06:58 cgoessni File Added: diff_timeActivatedFileUpdate.txt
2022-11-29 14:36 henry Assigned To => henry
2022-11-29 14:36 henry Status new => resolved
2022-11-29 14:36 henry Resolution open => fixed
2022-11-29 14:36 henry Fixed in Version => dev
2022-11-29 14:36 henry Note Added: 0012902