View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000673 | OpenFOAM | Bug | public | 2012-10-27 17:11 | 2012-10-27 21:27 |
| Reporter | wyldckat | Assigned To | henry | ||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000673: Inconsistency in defining PINC and PLIBS variables when using WM_MPLIB=SYSTEMOPENMPI | ||||
| Description | I've noticed only today this inconsistency, where in the file "etc/config/settings.sh" one can find these lines for the SYSTEMOPENMPI option: # Set compilation flags here instead of in wmake/rules/../mplibSYSTEMOPENMPI export PINC="`mpicc --showme:compile`" export PLIBS="`mpicc --showme:link`" But then in the General file "wmake/rules/General/mplibSYSTEMOPENMPI" we can find this: # use the system installed openmpi - mpicc must be installed PFLAGS = -DOMPI_SKIP_MPICXX PINC = $(shell mpicc --showme:compile) PLIBS = $(shell mpicc --showme:link) I believe the two lines on this last file should be removed or at least commented out by default... or perhaps the other way around, by commenting out in the "settings.h" file!? Nonetheless, I have not yet tested if things will still work as intended... This is in reference to the latest commit 949ec0dcff28d2e0f44aa62a28f3e328d65bffad. | ||||
| Additional Information | I only noticed this issue when giving some assistance on this thread and particular post: http://www.cfd-online.com/Forums/openfoam-installation/93341-system-openmpi-rhel-cluster.html#post388702 | ||||
| Tags | No tags attached. | ||||
|
|
I don't see the inconsistency: export PINC="`mpicc --showme:compile`" export PLIBS="`mpicc --showme:link`" and PINC = $(shell mpicc --showme:compile) PLIBS = $(shell mpicc --showme:link) look consistent to me. |
|
|
Sorry about that... The "inconsistency" I was trying to point out is because of this comment in the "settings.sh" file above the two export lines: # Set compilation flags here instead of in wmake/rules/../mplibSYSTEMOPENMPI If the user pays attention to this comment and only modifies "PINC" and "PLIBS" in "settings.sh" (as some have done by using the system's mpich2 or mvapich2, because it's convenient), he/she ends up having to back track the steps taken after the build and come to the conclusion that the comment is misleading, having then to set the values in both files, or to try commenting out the lines in the rule file. |
|
|
OK thanks for the clarification, I will review and fix |
|
|
Thanks for the bug-report. I have removed the creation of the additional environment variables from etc/config/settings.sh as this is better handled locally to the wmake system as for the other MPI implementations. Resolved by commit 8064dab1659afd6b54615458ef10f50d61d5793e |
|
|
You're welcome. I saw just now the fix and remembered+checked that "etc/config/settings.csh" should also get the same fix... |
|
|
Done but not tested. Please reopen if there are any issues. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-10-27 17:11 | wyldckat | New Issue | |
| 2012-10-27 18:21 | henry | Note Added: 0001750 | |
| 2012-10-27 19:10 | wyldckat | Note Added: 0001751 | |
| 2012-10-27 19:28 | henry | Note Added: 0001752 | |
| 2012-10-27 19:50 | henry | Note Added: 0001753 | |
| 2012-10-27 19:50 | henry | Status | new => resolved |
| 2012-10-27 19:50 | henry | Resolution | open => fixed |
| 2012-10-27 19:50 | henry | Assigned To | => henry |
| 2012-10-27 20:12 | wyldckat | Note Added: 0001754 | |
| 2012-10-27 20:12 | wyldckat | Status | resolved => feedback |
| 2012-10-27 20:12 | wyldckat | Resolution | fixed => reopened |
| 2012-10-27 21:27 | henry | Note Added: 0001755 | |
| 2012-10-27 21:27 | henry | Status | feedback => resolved |
| 2012-10-27 21:27 | henry | Resolution | reopened => fixed |
